[#754] Fix Farcaster wallet not showing in miniapp#758
Conversation
The hidden: () => !isLikelyFarcasterContext() check fails during SSR because window is undefined, causing the Farcaster wallet option to never appear in the miniapp. Since the connector gracefully fails outside Farcaster, it's safe to always show the option. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
Pure deletion, correct fix. The SSR issue meant isLikelyFarcasterContext() always returned false (no window on server), permanently hiding the Farcaster wallet. Removing the hidden property and the dead function is the cleanest solution since the connector already fails gracefully outside Farcaster. No concerns.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
This PR removes the SSR-dependent hidden gate from farcasterWallet and deletes the now-unused isLikelyFarcasterContext() helper, which matches issue #754 with a minimal single-file change.
Findings
- None.
Decision
Approving because the change is scoped to the reported root cause, follows the recommended fix from the issue, and does not introduce extra behavior beyond always showing the Farcaster wallet option.
2 participants
Summary
hidden: () => !isLikelyFarcasterContext()property fromfarcasterWalletinlib/wagmi.tsisLikelyFarcasterContext()functionhiddencheck ran during SSR wherewindowis undefined, causingisLikelyFarcasterContext()to always returnfalse, so the Farcaster wallet was never shown — even inside Warpcast miniappFixes #754
Test plan
npm run buildpasses🤖 Generated with Claude Code